depends on light hermes #49
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tclune
reviewed
Mar 19, 2020
tclune
reviewed
Mar 19, 2020
| @@ -7578,7 +7579,14 @@ subroutine Coldstart(gc, import, export, clock, rc) | |||
| bk_is_missing = .true. | |||
| endif | |||
|
|
|||
| if (ak_is_missing .or. bk_is_missing) call set_eta(km, ls, ptop, pint, AK, BK) | |||
| if (ak_is_missing .or. bk_is_missing) then | |||
There was a problem hiding this comment.
This duplicates logic above. It should be moved into an internal procedure and then just called from the two locations.
There was a problem hiding this comment.
The interfaces are different. I am not sure how to avoid the logic. Since it is already moved to init(), it is not a big issue.
tclune
reviewed
Mar 19, 2020
| @@ -326,7 +330,11 @@ program interp_restarts | |||
|
|
|||
| allocate ( r8_ak(npz+1) ) | |||
| allocate ( r8_bk(npz+1) ) | |||
| call set_eta(npz,ks,ptop,pint,r8_ak,r8_bk) | |||
| if (trim(eta_rc_file) == 'None') then | |||
There was a problem hiding this comment.
and duplicated again here ...
tclune
requested changes
Mar 19, 2020
tclune
reviewed
Mar 19, 2020
tclune
approved these changes
Mar 19, 2020
tclune
approved these changes
Mar 20, 2020
There was a problem hiding this comment.
Very nice.
If there were any changes, I might ask that you modify the name of the internal state. Conventionally these are named after the component itself, though I think your name is much clearer. So please leave it as is, but be prepared to switch it if anyone asks.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This merge requires the merge of GMAO_Shared branch feature/wjiang/#149-add_write_eta which provide the module shared_topo_remap